feat(color): allow all valid CSS colors #2381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the following notation styles - Hex number colors - hsl / hsla color functions - named colors - space separated function notation - decimal numbers in colors - percentages in colors - exponent numbers - deg / rad / turn unit in hue DEPREDATED: Use Color.parseString() instead of Color.parseRgbString()
straker
approved these changes
Jul 16, 2020
| */ | ||
| this.parseString = function(colorString) { | ||
| // IE occasionally returns named colors instead of RGB(A) values | ||
| if (standards.cssColors[colorString] || colorString === 'transparent') { |
There was a problem hiding this comment.
Would it make sense to have transparent be a named color with vales of [0, 0, 0] rather than special casing it three times? (first in the if, again with the color assignment of || [0,0,0], and last with the alpha). We could just only special case the alpha if it's transparent if it was a named color.
There was a problem hiding this comment.
Thought about that, but I don't think that's all that clean of a solution. I had it in a separate if statement at first. I can put that back in if you prefer. Personally, this seems fine to me.
straker
previously requested changes
Jul 16, 2020
WilcoFiers
changed the title
straker
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the following notation styles
DEPREDATED: Color.parseRgbString() is replaced by Color.parseString()
This PR is a prerequisite for #2334
Reviewer checks
Required fields, to be filled out by PR reviewer(s)